cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefania (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-8592) Add WriteFailureException
Date Wed, 11 Mar 2015 03:01:39 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-8592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14356143#comment-14356143
] 

Stefania commented on CASSANDRA-8592:
-------------------------------------

bq. Right, I think it would be fine to make it a checked exception.

This means changing the signature of every verb handler, are you sure?

bq. Hmm, JVM_EXTRA_OPTS should still be picked by in cassandra-env.sh when that's sourced.
A quick test with ccm on the commandline seems to indicate that it works.

I must have had some other problem, it definitely is working as it is. Please ignore the ccm
change I suggested.

bq. Dtests changes should normally be committed right after the Cassandra changes are committed.
You can open a pull request for those as well.
bq. As for the python driver, once the Cassandra changes are committed, we can start a ticket
at https://datastax-oss.atlassian.net/projects/PYTHON and link to a branch with our suggested
changes. (The driver maintainer may want to take a different approach.)

I will open the dtest pull request and the python driver ticket as soon as this is committed.


bq. The javadoc for StorageProxy.hintMutations needs to be updated

Done, thank you.

bq. Why did you make AbstractWriteResponseHandler generic? It doesn't seem like that's required
or buys us anything. If I've missed something and there is value in making it generic, it
looks like a few more changes are required (I spotted some usages in StorageProxy that don't
use the generic class version).

It was already generic, I simply added the generic arguments as I got carried away fixing
compiler warnings. {{AbstractWriteResponseHandler}} is generic because it extends {{IAsyncCallback}},
which is generic on the message payload. The payload for {{AbstractWriteResponseHandler}}
can be {{IMutation}} ({{Mutation}} or {{CounterMutation}}) or {{Commit}}. Because this latter
does not extend {{IMutation}} we need to keep {{AbstractWriteResponseHandler}} generic. I
tried to fix all the warnings in {{StorageProxy}}. Let me know if you see more. BTW, do you
guys perhaps have a different policy to leave alone unrelated things such as compiler warnings?
I am happy to undo.

bq. The new dtest module has a lot of unused imports

Left overs from previous attempts! Fixed, thank you for spotting it.

bq. Since the dtest depends on having CURRENT_VERSION set to VERSION_4, go ahead and update
CURRENT_VERSION in your branch.

Done, thank you.

> Add WriteFailureException
> -------------------------
>
>                 Key: CASSANDRA-8592
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8592
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: API, Core
>            Reporter: Tyler Hobbs
>            Assignee: Stefania
>              Labels: client-impacting
>             Fix For: 3.0
>
>
> Similar to what CASSANDRA-7886 did for reads, we should add a WriteFailureException and
have replicas signal a failure while handling a write to the coordinator.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message