cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joshua McKenzie (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-8584) Add strerror output on failed trySkipCache calls
Date Tue, 10 Mar 2015 20:17:38 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355606#comment-14355606
] 

Joshua McKenzie commented on CASSANDRA-8584:
--------------------------------------------

bq. Can we simply pass a String path to trySkipCache...
That works. CommitLogSegment does't have getFilename but we can reconstruct from logFile easily
enough and that's much cleaner.
bq. If we're renaming the descriptors...
Renamed to sourceDataDescriptors. I think File is implicit in the context.
bq. It's probably worth porting the log message to use the varargs parameter of the warn()
method.
Not exactly sure what you mean as ThrottledLogger.warn() was using varargs, and why only warn()...
But if you meant to include Objects[] in the hash for throttling in the log *method*, I added
that and added a unit test to sanity check as well.

Branch updated.

> Add strerror output on failed trySkipCache calls
> ------------------------------------------------
>
>                 Key: CASSANDRA-8584
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8584
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Joshua McKenzie
>            Assignee: Joshua McKenzie
>            Priority: Trivial
>             Fix For: 2.1.4
>
>         Attachments: 8584_v1.txt, nospamlogger.txt
>
>
> Since trySkipCache returns an errno rather than -1 and setting errno like our other CLibrary
calls, it's thread-safe and we could print out more helpful information if we failed to prompt
the kernel to skip the page cache.  That system call should always succeed unless we have
an invalid fd as it's free to ignore us.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message