cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ariel Weisberg (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-8584) Add strerror output on failed trySkipCache calls
Date Tue, 24 Mar 2015 21:55:54 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14378728#comment-14378728
] 

Ariel Weisberg commented on CASSANDRA-8584:
-------------------------------------------

Throttling isn't about reducing the amount of information in the log. It's about making it
possible to include information that you woudln't be able to without some kind of coordination
that ensures you don't flood the log. This isn't a proposal to throttle all messages by default.
It's opt-in for special cases where you know it could be disruptive.

We should really be talking about this in CASSANDRA-9029

> Add strerror output on failed trySkipCache calls
> ------------------------------------------------
>
>                 Key: CASSANDRA-8584
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8584
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Joshua McKenzie
>            Assignee: Joshua McKenzie
>            Priority: Trivial
>             Fix For: 2.1.4
>
>         Attachments: 8584_v1.txt, NoSpamLogger.java, nospamlogger.txt
>
>
> Since trySkipCache returns an errno rather than -1 and setting errno like our other CLibrary
calls, it's thread-safe and we could print out more helpful information if we failed to prompt
the kernel to skip the page cache.  That system call should always succeed unless we have
an invalid fd as it's free to ignore us.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message