cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Stupp (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-8584) Add strerror output on failed trySkipCache calls
Date Tue, 24 Mar 2015 21:33:54 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14378678#comment-14378678
] 

Robert Stupp commented on CASSANDRA-8584:
-----------------------------------------

I'm pro and contra regarding log-throttling.
Pro, because it may limit the amount of "spam" in the log file (e.g. hundreds of "batch too
big" messages)
Contra, because it may hide the importance of a message (amount of messages _is_ is the level
of importance)
OTOH - who really *reads* log files (especially in a big cluster)? What I want to say is:
is a log _file_ really the place where _important_ should go to? I think there are some solutions
out there that do some log file scanning and aggregation and alerting.

LD;DR IMO we should stick with system.log but think of something or use/add support for something
that really adds value for operators of both small and big clusters.

> Add strerror output on failed trySkipCache calls
> ------------------------------------------------
>
>                 Key: CASSANDRA-8584
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8584
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Joshua McKenzie
>            Assignee: Joshua McKenzie
>            Priority: Trivial
>             Fix For: 2.1.4
>
>         Attachments: 8584_v1.txt, NoSpamLogger.java, nospamlogger.txt
>
>
> Since trySkipCache returns an errno rather than -1 and setting errno like our other CLibrary
calls, it's thread-safe and we could print out more helpful information if we failed to prompt
the kernel to skip the page cache.  That system call should always succeed unless we have
an invalid fd as it's free to ignore us.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message