cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ariel Weisberg (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CASSANDRA-8584) Add strerror output on failed trySkipCache calls
Date Tue, 24 Mar 2015 15:48:53 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Ariel Weisberg updated CASSANDRA-8584:
--------------------------------------
    Attachment: NoSpamLogger.java

Kitchen sink version of NoSpamLogger.

It's now lock free and nonblocking to check whether something should be logged.

Constructor is private ensuring that only one instance of each wrapper exists.

It's possible to supply your own timestamps when logging (frequently you already know the
time).

You also don't need to construct and keep around a wrapper to invoke a static method that
will retrieve (or construct) the wrapper on demand.

> Add strerror output on failed trySkipCache calls
> ------------------------------------------------
>
>                 Key: CASSANDRA-8584
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8584
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Joshua McKenzie
>            Assignee: Joshua McKenzie
>            Priority: Trivial
>             Fix For: 2.1.4
>
>         Attachments: 8584_v1.txt, NoSpamLogger.java, nospamlogger.txt
>
>
> Since trySkipCache returns an errno rather than -1 and setting errno like our other CLibrary
calls, it's thread-safe and we could print out more helpful information if we failed to prompt
the kernel to skip the page cache.  That system call should always succeed unless we have
an invalid fd as it's free to ignore us.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message