cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nick Bailey (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-8348) allow takeColumnFamilySnapshot to take a list of ColumnFamilies
Date Tue, 31 Mar 2015 17:04:53 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14388846#comment-14388846
] 

Nick Bailey edited comment on CASSANDRA-8348 at 3/31/15 5:04 PM:
-----------------------------------------------------------------

Unfortunately the patch doesn't apply to 2.1 anymore. Sorry for the delay, can you update
the patch [~SachinJanani]?

The code looks pretty good to me except I think you call getValidKeyspace() on the same keyspace
twice. Also it looks like your IDE auto expanded any '\*' imports. I don't remember what the
c\* team's policy on that is.


was (Author: nickmbailey):
Unfortunately the patch doesn't apply to 2.1 anymore. Sorry for the delay, can you update
the patch [~SachinJanani]?

The code looks pretty good to me except I think you call getValidKeyspace() on the same keyspace
twice. Also it looks like your IDE auto expanded any '*' imports. I don't remember what the
c* team's policy on that is.

> allow takeColumnFamilySnapshot to take a list of ColumnFamilies
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-8348
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8348
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Peter Halliday
>            Priority: Minor
>             Fix For: 2.1.4
>
>         Attachments: Patch-8348.patch
>
>
> Within StorageServiceMBean.java the function takeSnapshot allows for a list of keyspaces
to snapshot.  However, the function takeColumnFamilySnapshot only allows for a single ColumnFamily
to snapshot.  This should allow for multiple ColumnFamilies within the same Keyspace.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message