cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Stupp (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-7807) Push notification when tracing completes for an operation
Date Sun, 29 Mar 2015 11:40:53 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-7807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14385718#comment-14385718
] 

Robert Stupp commented on CASSANDRA-7807:
-----------------------------------------

{{ServerConnection.java}} 
done

{{debug-cql}} 
no, did not forget. Otherwise {{debug-cql}} would not start if any other process (C*) uses
port 7199 - i.e. {{debug-cql}} would not start if C* is running locally). It’s probably
better handled in a separate ticket - or we decide to remove sourcing of {{cassandra-env.sh}}
at all for {{debug-cql}}. Not sure about either way.

{{SimpleClient.java}} / {{TransportException}}
Yea - it’s a bit awkward. But TE is only implemented by C* exceptions that extend RuntimeException.
These are: {{ServerError}}, {{ProtocolException}} and {{CassandraException}}. Eventually it
makes more sense to let {{ServerError}} and {{ProtocolException}} extend {{CassandraException}}
and get rid {{TransportException}}. We already have an ”exception cleanup ticket” for
3.0 (CASSANDRA-8809) - maybe it’s worth to cleanup this, too.

{{TraceCompleteTest.java}}
Worked in the increased timeout.

Also changed the code to deal better with trace probability (via an explicit boolean whether
the event should be sent or not). Maybe I counted too much on the ”correct” result of
the test.

Let me know what you thing about the TE and debug-cql things and I'll provide a matching patch
for that. The branch's updated.

> Push notification when tracing completes for an operation
> ---------------------------------------------------------
>
>                 Key: CASSANDRA-7807
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7807
>             Project: Cassandra
>          Issue Type: Sub-task
>          Components: Core
>            Reporter: Tyler Hobbs
>            Assignee: Robert Stupp
>            Priority: Minor
>              Labels: client-impacting, protocolv4
>             Fix For: 3.0
>
>         Attachments: 7807-v2.txt, 7807-v3.txt, 7807.txt
>
>
> Tracing is an asynchronous operation, and drivers currently poll to determine when the
trace is complete (in a loop with sleeps).  Instead, the server could push a notification
to the driver when the trace completes.
> I'm guessing that most of the work for this will be around pushing notifications to a
single connection instead of all connections that have registered listeners for a particular
event type.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message