cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefania (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-5174) expose nodetool scrub for 2Is
Date Fri, 20 Mar 2015 01:03:32 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-5174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14370475#comment-14370475
] 

Stefania commented on CASSANDRA-5174:
-------------------------------------

[~yukim] thank you for your review! 

Here is the latest commit: https://github.com/apache/cassandra/commit/b018430c17cf15915f9b2c2d4dd4e8689cf058b8

bq. I think we should log only when we are rebuilding index, and change log level to WARN,
since default exception handler will log in ERROR anyway. 
Done, however I wanted this message to be logged before or together with the "Rebuilding index..."
message so I passed the {{throwable}} as an argument to {{rebuildOnFailedScrub()}}, see if
that's OK.

bq. Why don't you handle IllegalArgumentException in its own catch block? 
Good point, done.

bq. dtest also looks good except coding styles (docstring, string format) but I let QA team
take a look when you do pull request.
This is the pull request, I explicitly asked them to pick up style issues: https://github.com/riptano/cassandra-dtest/pull/200

I have one more question, since I know people can implement custom indexes, are the changes
I made to {{SecondaryIndex}} going to cause issues or is this expected in a major release?

> expose nodetool scrub for 2Is
> -----------------------------
>
>                 Key: CASSANDRA-5174
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5174
>             Project: Cassandra
>          Issue Type: Task
>          Components: Core, Tools
>            Reporter: Jason Brown
>            Assignee: Stefania
>            Priority: Minor
>             Fix For: 3.0
>
>
> Continuation of CASSANDRA-4464, where many other nodetool operations were added for 2Is.
This ticket supports scrub fo 2Is and is in its own ticket due to the riskiness of deleting
data on a bad bug.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message