Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Fri, 13 Feb 2015 18:39:12 +0000 (UTC)
From: "Joshua McKenzie (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12774952.1423845730000.41757.1423852752286@Atlassian.JIRA>
In-Reply-To: <JIRA.12774952.1423845730000@Atlassian.JIRA>
References: <JIRA.12774952.1423845730000@Atlassian.JIRA>
 <JIRA.12774952.1423845730281@arcas>
Subject: [jira] [Commented] (CASSANDRA-8802) Leaked reference on windows
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-8802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14320530#comment-14320530 ] 

Joshua McKenzie commented on CASSANDRA-8802:
--------------------------------------------

Code looks reasonable to me.  [~philipthompson]: could you confirm the attached patch resolves the error that's showing up on the referenced dtest? (should be committed either way since benedict is spot-on about that being an error recovery gap)

> Leaked reference on windows
> ---------------------------
>
>                 Key: CASSANDRA-8802
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8802
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Philip Thompson
>            Assignee: Benedict
>             Fix For: 2.1.4
>
>         Attachments: 8802.txt
>
>
> The dtest counter_tests.py:TestCounters.upgrade_test is failing on Windows with the following error:
> {code}
> ERROR [Reference-Reaper:1] 2015-02-13 11:06:17,802 Ref.java:167 - LEAK DETECTED: a reference (org.apache.cassandra.utils.concurrent.Ref$State@2d0bdc9) to class org.apache.cassandra.utils.concurrent.WrappedSharedCloseable$1@669450811:[OffHeapBitSet] was not released before the reference was garbage collected
> {code}
> This exception is not occurring on Linux or OSX. The test is also erroring from CASSANDRA-8535.
> /cc [~benedict] [~JoshuaMcKenzie]


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)