Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BE90A10690 for ; Mon, 9 Feb 2015 19:21:39 +0000 (UTC) Received: (qmail 14348 invoked by uid 500); 9 Feb 2015 19:21:35 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 14320 invoked by uid 500); 9 Feb 2015 19:21:35 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 14285 invoked by uid 99); 9 Feb 2015 19:21:35 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Feb 2015 19:21:35 +0000 Date: Mon, 9 Feb 2015 19:21:35 +0000 (UTC) From: "Yuki Morishita (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-8744) Ensure SSTableReader.first/last are honoured universally MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14312688#comment-14312688 ] Yuki Morishita commented on CASSANDRA-8744: ------------------------------------------- Patch (63d3c54ade5c15fafb0ac129e0bf101fb88afc1a) LGTM. +1. > Ensure SSTableReader.first/last are honoured universally > -------------------------------------------------------- > > Key: CASSANDRA-8744 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8744 > Project: Cassandra > Issue Type: Bug > Components: Core > Reporter: Benedict > Assignee: Benedict > Priority: Critical > Fix For: 2.1.4 > > > Split out from CASSANDRA-8683; we don't honour the first/last properties of an sstablereader, and we tend to assume that we do. This can cause problems in LCS validation compactions, for instance, where a scanner is assumed to only cover the defined range, but may return data either side of that range. In general it is only wasteful to not honour these ranges anyway. -- This message was sent by Atlassian JIRA (v6.3.4#6332)