Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5226210D3A for ; Thu, 19 Feb 2015 19:40:12 +0000 (UTC) Received: (qmail 85347 invoked by uid 500); 19 Feb 2015 19:40:12 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 85260 invoked by uid 500); 19 Feb 2015 19:40:12 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 85123 invoked by uid 99); 19 Feb 2015 19:40:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Feb 2015 19:40:12 +0000 Date: Thu, 19 Feb 2015 19:40:11 +0000 (UTC) From: "Benedict (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-8709) Convert SequentialWriter from using RandomAccessFile to nio channel MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-8709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328006#comment-14328006 ] Benedict commented on CASSANDRA-8709: ------------------------------------- I think a case can be made to move SegmentedFile to this instead of RAR as well. This would permit us to avoid creating a separate file handle for either each instance _or_ each reader. Since we're only competing against other buffered readers here (not touching mmapping), I think the improvement could be well worthwhile, and likely have no downside. There may be some follow on benefits as well, by being able to refactor our writing a little to eliminate both TMP and TMPLINK files. > Convert SequentialWriter from using RandomAccessFile to nio channel > ------------------------------------------------------------------- > > Key: CASSANDRA-8709 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8709 > Project: Cassandra > Issue Type: Improvement > Reporter: Joshua McKenzie > Assignee: Joshua McKenzie > Labels: Windows > Fix For: 3.0 > > > For non-mmap'ed I/O on Windows, using nio channels will give us substantially more flexibility w/regards to renaming and moving files around while writing them. This change in conjunction with CASSANDRA-4050 should allow us to remove the Windows bypass code in SSTableRewriter for non-memory-mapped I/O. > In general, migrating from instances of RandomAccessFile to nio channels will help make Windows and linux behavior more consistent. -- This message was sent by Atlassian JIRA (v6.3.4#6332)