Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 374EC17E90 for ; Thu, 5 Feb 2015 15:02:36 +0000 (UTC) Received: (qmail 53078 invoked by uid 500); 5 Feb 2015 15:02:36 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 53043 invoked by uid 500); 5 Feb 2015 15:02:36 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 53031 invoked by uid 99); 5 Feb 2015 15:02:36 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Feb 2015 15:02:36 +0000 Date: Thu, 5 Feb 2015 15:02:35 +0000 (UTC) From: "T Jake Luciani (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-8707) Move SegmentedFile, IndexSummary and BloomFilter to utilising RefCounted MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-8707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14307337#comment-14307337 ] T Jake Luciani commented on CASSANDRA-8707: ------------------------------------------- I want to give this code time to bake and give users some relief in the meantime with the other ~100 fixes in 2.1.3. I suggest we push this to 2.1.4 as well as CASSANDRA-8683 and CASSANDRA-8744. I suggest we disable incremental compaction for 2.1.3 which should avoid most of these bugs. > Move SegmentedFile, IndexSummary and BloomFilter to utilising RefCounted > ------------------------------------------------------------------------ > > Key: CASSANDRA-8707 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8707 > Project: Cassandra > Issue Type: Bug > Reporter: Benedict > Assignee: Benedict > Priority: Critical > Fix For: 2.1.3 > > > There are still a few bugs with resource management, especially around SSTableReader cleanup, esp. when intermixing with compaction. This migration should help. We can simultaneously "simplify" the logic in SSTableReader to not track the replacement chain, only to take a new reference to each of the underlying resources. -- This message was sent by Atlassian JIRA (v6.3.4#6332)