Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Tue, 3 Feb 2015 14:15:35 +0000 (UTC)
From: "Benedict (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12770094.1422281876000.241475.1422972935664@Atlassian.JIRA>
In-Reply-To: <JIRA.12770094.1422281876000@Atlassian.JIRA>
References: <JIRA.12770094.1422281876000@Atlassian.JIRA>
 <JIRA.12770094.1422281876420@arcas>
Subject: [jira] [Commented] (CASSANDRA-8683) Ensure early reopening has no
 overlap with replaced files, and that SSTableReader.first/last are honoured
 universally
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-8683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14303309#comment-14303309 ] 

Benedict commented on CASSANDRA-8683:
-------------------------------------

That patch is for the prior description of the ticket. I will be posting a new patch this afternoon.

> Ensure early reopening has no overlap with replaced files, and that SSTableReader.first/last are honoured universally
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-8683
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8683
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Marcus Eriksson
>            Assignee: Benedict
>            Priority: Critical
>             Fix For: 2.1.3
>
>         Attachments: 0001-avoid-NPE-in-getPositionsForRanges.patch
>
>
> Incremental repairs holds a set of the sstables it started the repair on (we need to know which sstables were actually validated to be able to anticompact them). This includes any tmplink files that existed when the compaction started (if we wouldn't include those, we would miss data since we move the start point of the existing non-tmplink files)
> With CASSANDRA-6916 we swap out those instances with new ones (SSTR.cloneWithNewStart / SSTW.openEarly), meaning that the underlying file can get deleted even though we hold a reference.
> This causes the unit test error: http://cassci.datastax.com/job/trunk_utest/1330/testReport/junit/org.apache.cassandra.db.compaction/LeveledCompactionStrategyTest/testValidationMultipleSSTablePerLevel/
> (note that it only fails on trunk though, in 2.1 we don't hold references to the repairing files for non-incremental repairs, but the bug should exist in 2.1 as well)


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)