cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Ellis (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (CASSANDRA-8862) Commit log pending tasks incremented during getPendingTasks
Date Thu, 26 Feb 2015 05:25:05 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-8862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jonathan Ellis resolved CASSANDRA-8862.
---------------------------------------
    Resolution: Fixed

You're right, that is a mistake.  Fixed in 2c15d8212020022f0cf9e101772169b5dc541ae4

> Commit log pending tasks incremented during getPendingTasks
> -----------------------------------------------------------
>
>                 Key: CASSANDRA-8862
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8862
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Michael Swiecicki
>            Assignee: Jonathan Ellis
>            Priority: Minor
>             Fix For: 2.1.4
>
>
> After upgrading from Cassandra 2.0.8 to 2.1.2 our monitoring based on JMX metrics shows
increasing number of commit log pending tasks. From what we found out, this value is now incremented
every time it is fetched.
> It is easy to reproduce using tool like JConsole by refreshing value of PendingTasks
attribute.
> Quick look at the code shows that this behavior was probably introduced in 2.1 with CASSANDRA-3578
where getPendingTasks in AbstractCommitLogService was changed from returning queue.size()
to returning pending.incrementAndGet(). As a result this counter is incremented when getting
value of Commitlog.PendingTasks from org.apache.cassandra.db (now deprecated) or CommitLog.PendingTasks
from org.apache.cassandra.metrics.
> Could you please clarify if this is expected behavior?
> This was already mentioned in CASSANDRA-8531.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message