cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedict (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-8792) Improve Memory assertions
Date Thu, 12 Feb 2015 19:13:11 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-8792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14318786#comment-14318786
] 

Benedict commented on CASSANDRA-8792:
-------------------------------------

I would prefer the caller to enforce this where necessary, since there's no good reason to
absolutely refuse an empty memory object, so we may unnecessarily break something. If we in
future have to relax it, we also run the risk of doing so inconsistently and relying on the
assumption elsewhere.

I don't feel too strongly one way or the other though.

> Improve Memory assertions
> -------------------------
>
>                 Key: CASSANDRA-8792
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8792
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Benedict
>            Assignee: Benedict
>            Priority: Trivial
>             Fix For: 2.1.4
>
>
> Null pointers are valid returns if a size of zero is returned. We assume a null pointer
implies resource mismanagement in a few places. We also don't properly check the bounds of
all of our accesses; this patch attempts to tidy up both of these things.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message