cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedict (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-8750) Ensure SSTableReader.last corresponds exactly with the file end
Date Tue, 24 Feb 2015 14:23:05 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-8750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334898#comment-14334898
] 

Benedict edited comment on CASSANDRA-8750 at 2/24/15 2:22 PM:
--------------------------------------------------------------

This was broken from the get go for compressed files, which we don't cover by default in our
unit tests. The fix was very simple, but I've also made the SSTableRewriterTest work for compressed
files. Patch available [here|https://github.com/belliottsmith/cassandra/tree/8750-fix]


was (Author: benedict):
This was broken from the get go for compressed files, which we don't cover by default in our
unit tests. The fix was very simple, but I've also made the SSTableRewriterTest work for compressed
files. Patch available [here|github.com/belliottsmith/cassandra/tree/8750-fix]

> Ensure SSTableReader.last corresponds exactly with the file end
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-8750
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8750
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Benedict
>            Assignee: Benedict
>            Priority: Minor
>             Fix For: 2.1.4
>
>
> Following on from CASSANDRA-8744, CASSANDRA-8749 and CASSANDRA-8747, this patch attempts
to make the whole opening early of compaction results more robust and with more clearly understood
behaviour. The improvements of CASSANDRA-8747 permit is to easily align the last key with
a summary boundary, and an index and data file end position. This patch modifies SegmentedFile
to permit the provision of an explicit length, which is then provided to any readers, which
enforce it, ensuring no code may accidentally see an end inconsistent with the one advertised.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message