cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedict (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-8707) Move SegmentedFile, IndexSummary and BloomFilter to utilising RefCounted
Date Wed, 04 Feb 2015 14:30:35 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-8707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14305155#comment-14305155
] 

Benedict commented on CASSANDRA-8707:
-------------------------------------

Special casing is where many of our recent bugs have come from, as far as I can tell. They
interplay with each other in ways we cannot easily predict, especially when focusing on one
area of the codebase. We think "it'll be fine here, as it doesn't touch anything else, and
I've got a handle on what it does" - then we remember validation compaction in LCS that breaks
our assumption, for instance.

> Move SegmentedFile, IndexSummary and BloomFilter to utilising RefCounted
> ------------------------------------------------------------------------
>
>                 Key: CASSANDRA-8707
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8707
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Benedict
>            Assignee: Benedict
>            Priority: Critical
>             Fix For: 2.1.3
>
>
> There are still a few bugs with resource management, especially around SSTableReader
cleanup, esp. when intermixing with compaction. This migration should help. We can simultaneously
"simplify" the logic in SSTableReader to not track the replacement chain, only to take a new
reference to each of the underlying resources.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message