cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benedict (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-8692) Coalesce intra-cluster network messages
Date Fri, 20 Feb 2015 09:30:14 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-8692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328732#comment-14328732
] 

Benedict commented on CASSANDRA-8692:
-------------------------------------

[~aweisberg] thanks for clarifying that method call. And I like the use of "Preconditions".
But I'm not sure the single precondition check requires a whole extra nested method call?
I realised when I woke up the thing that was bugging me was the inconsistency between the
first call to drainTo() which _did_ assume the list was empty (by not subtracting out.size())
and the proceeding calls which assumed it had not been empty. So, so long as they are consistent
I'm happy. Although I still prefer the way it is currently... I just find the extra method
for one precondition check a bit ugly. I'll let you make the final call on this though.

> Coalesce intra-cluster network messages
> ---------------------------------------
>
>                 Key: CASSANDRA-8692
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8692
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Ariel Weisberg
>            Assignee: Ariel Weisberg
>             Fix For: 2.1.4
>
>         Attachments: batching-benchmark.png
>
>
> While researching CASSANDRA-8457 we found that it is effective and can be done without
introducing additional latency at low concurrency/throughput.
> The patch from that was used and found to be useful in a real life scenario so I propose
we implement this in 2.1 in addition to 3.0.
> The change set is a single file and is small enough to be reviewable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message