cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marcus Eriksson (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-8683) Ensure early reopening has no overlap with replaced files
Date Mon, 09 Feb 2015 08:42:34 GMT


Marcus Eriksson commented on CASSANDRA-8683:

could you update the description of the ticket and describe how the patch fixes it?

> Ensure early reopening has no overlap with replaced files
> ---------------------------------------------------------
>                 Key: CASSANDRA-8683
>                 URL:
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Marcus Eriksson
>            Assignee: Benedict
>            Priority: Critical
>             Fix For: 2.1.3
>         Attachments: 0001-avoid-NPE-in-getPositionsForRanges.patch
> Incremental repairs holds a set of the sstables it started the repair on (we need to
know which sstables were actually validated to be able to anticompact them). This includes
any tmplink files that existed when the compaction started (if we wouldn't include those,
we would miss data since we move the start point of the existing non-tmplink files)
> With CASSANDRA-6916 we swap out those instances with new ones (SSTR.cloneWithNewStart
/ SSTW.openEarly), meaning that the underlying file can get deleted even though we hold a
> This causes the unit test error:
> (note that it only fails on trunk though, in 2.1 we don't hold references to the repairing
files for non-incremental repairs, but the bug should exist in 2.1 as well)

This message was sent by Atlassian JIRA

View raw message