cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joshua McKenzie (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-8308) Windows: Commitlog access violations on unit tests
Date Thu, 12 Feb 2015 19:49:11 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-8308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14318864#comment-14318864
] 

Joshua McKenzie commented on CASSANDRA-8308:
--------------------------------------------

Got Philip to run it against a Windows CI (thanks) - results are [here|http://cassci.datastax.com/job/8308_trunk_utest_win32/lastBuild/testReport/].
 Looks like it's resolved the issue however before we commit I have a couple of questions
and one concern:

Why 10 retries and why 500ms sleep between retries on closeAndDeleteSegmentUnsafe (vs. 5 and
10ms, for instance, or some other arbitrary number)?  The "keep trying to delete it until
it works or eventually we time out" smells a lot like a micro-version of SSTableDeletingTask
for CLS where we're just spinning locally instead of scheduling off GC.  More limited in scope
(also only applies to tests) but equally hackish.

This may very well be the best we can do on Windows if we're in an environment where filesystem
drivers can't be trusted to consistently stay out of our way and mangle up our deleteRecursive
calls (which is looking more and more like the case) - but I think it's best we have a clear
view of the pig before we put lipstick on it and call it a day.

> Windows: Commitlog access violations on unit tests
> --------------------------------------------------
>
>                 Key: CASSANDRA-8308
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8308
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Joshua McKenzie
>            Assignee: Joshua McKenzie
>            Priority: Minor
>              Labels: Windows
>             Fix For: 3.0
>
>         Attachments: 8308-post-fix-3.txt, 8308-post-fix.txt, 8308_v1.txt, 8308_v2.txt,
8308_v3.txt
>
>
> We have four unit tests failing on trunk on Windows, all with FileSystemException's related
to the SchemaLoader:
> {noformat}
> [junit] Test org.apache.cassandra.db.compaction.DateTieredCompactionStrategyTest FAILED
> [junit] Test org.apache.cassandra.cql3.ThriftCompatibilityTest FAILED
> [junit] Test org.apache.cassandra.io.sstable.SSTableRewriterTest FAILED
> [junit] Test org.apache.cassandra.repair.LocalSyncTaskTest FAILED
> {noformat}
> Example error:
> {noformat}
>     [junit] Caused by: java.nio.file.FileSystemException: build\test\cassandra\commitlog;0\CommitLog-5-1415908745965.log:
The process cannot access the file because it is being used by another process.
>     [junit]
>     [junit]     at sun.nio.fs.WindowsException.translateToIOException(WindowsException.java:86)
>     [junit]     at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:97)
>     [junit]     at sun.nio.fs.WindowsException.rethrowAsIOException(WindowsException.java:102)
>     [junit]     at sun.nio.fs.WindowsFileSystemProvider.implDelete(WindowsFileSystemProvider.java:269)
>     [junit]     at sun.nio.fs.AbstractFileSystemProvider.delete(AbstractFileSystemProvider.java:103)
>     [junit]     at java.nio.file.Files.delete(Files.java:1079)
>     [junit]     at org.apache.cassandra.io.util.FileUtils.deleteWithConfirm(FileUtils.java:125)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message