cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chinmay Gupte (JIRA)" <>
Subject [jira] [Updated] (CASSANDRA-6719) redesign loadnewsstables
Date Sun, 01 Feb 2015 22:32:36 GMT


Chinmay Gupte updated CASSANDRA-6719:
    Attachment: 6719.patch

I have been poking around this a bit and have attached a patch. It allows a path for a staging
directory to be passed with `CFSMBean.loadNewSSTables` and loads new sstables from it. Consider
it kinda WIP, mostly because I am not sure if its sufficient and will appreciate a review.
Few questions:

1. This might be one of the dumber questions, so please bear with me, but I see `CFSMBean.loadNewSSTables`
being used by `StorageService.loadNewSSTables(String, String)` as well, and eventually by
NodeProbe, so I believe there will be changes required in that part of code as well. Are those
changes not mentioned in the description of the ticket, because they are too obvious or is
there anything else?
2. Currently if the parameter for staging directory is not passed, it will default to loading
the sstables from the live data dirs. I believe this is not the expected behavior and we should
force supplying a parameter, no matter what. But I want to get some opinions before I make
this change. 

> redesign loadnewsstables
> ------------------------
>                 Key: CASSANDRA-6719
>                 URL:
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Tools
>            Reporter: Jonathan Ellis
>            Priority: Minor
>              Labels: lhf
>             Fix For: 3.0
>         Attachments: 6719.patch
> CFSMBean.loadNewSSTables scans data directories for new sstables dropped there by an
external agent.  This is dangerous because of possible filename conflicts with existing or
newly generated sstables.
> Instead, we should support leaving the new sstables in a separate directory (specified
by a parameter, or configured as a new location in yaml) and take care of renaming as necessary

This message was sent by Atlassian JIRA

View raw message