Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B5AA617A96 for ; Thu, 29 Jan 2015 18:47:35 +0000 (UTC) Received: (qmail 28045 invoked by uid 500); 29 Jan 2015 18:47:35 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 27936 invoked by uid 500); 29 Jan 2015 18:47:35 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 27812 invoked by uid 99); 29 Jan 2015 18:47:35 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 29 Jan 2015 18:47:35 +0000 Date: Thu, 29 Jan 2015 18:47:35 +0000 (UTC) From: "Thomas Steinmaurer (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-8685) Consider upgrade to thrift 0.9.2 (or later) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-8685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14297323#comment-14297323 ] Thomas Steinmaurer commented on CASSANDRA-8685: ----------------------------------------------- {quote} Can you drop this in without re-compiling? {quote} Yes. * Stopping Cassandra 2.0.11 * Replacing thrift library 0.9.1 with 0.9.2 * Starting Cassandra 2.0.11 Haven't seen any sign of troubles in the Cassandra log or Astyanax based log in our application. To be honest I had hoped that it will be considered even for 2.0.x public. I have no idea about other users roadmap regarding 2.1 in production, but we are moving from 1.2.15 (DSE 3.2.5) to 2.0.11 (DSE 4.5.3) in production soon and will settle with 2.0 for at least this year I guess. Anyway, thanks for your swift reply here! > Consider upgrade to thrift 0.9.2 (or later) > ------------------------------------------- > > Key: CASSANDRA-8685 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8685 > Project: Cassandra > Issue Type: Bug > Reporter: Adam Hattrell > Assignee: T Jake Luciani > Fix For: 2.1.3 > > Attachments: thrift1457fix_cassandra_heap.png, thrift1457fix_cassandra_heap_framedtransport.png > > > Folks using Astyanax and the like are subject to https://issues.apache.org/jira/browse/THRIFT-1457 and may run into heap pressure on the Cassandra side for larger read request, as thrift doesn't reset its internal buffer. This can lead to larger TFramedTransport instances will be kept on the heap. > I've seen at least one situation where this has saved around 1Gb of heap space on average. -- This message was sent by Atlassian JIRA (v6.3.4#6332)