Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DA0D11031F for ; Mon, 12 Jan 2015 11:33:33 +0000 (UTC) Received: (qmail 25365 invoked by uid 500); 12 Jan 2015 11:33:35 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 25331 invoked by uid 500); 12 Jan 2015 11:33:35 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 25319 invoked by uid 99); 12 Jan 2015 11:33:35 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Jan 2015 11:33:35 +0000 Date: Mon, 12 Jan 2015 11:33:35 +0000 (UTC) From: "Marcus Eriksson (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (CASSANDRA-8562) Fix checking available disk space before compaction starts MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-8562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14273482#comment-14273482 ] Marcus Eriksson edited comment on CASSANDRA-8562 at 1/12/15 11:32 AM: ---------------------------------------------------------------------- [~JoshuaMcKenzie] attaching the 2.1-patch, seems we have a bug in CompactionTask#reduceForLimitedScope since CASSANDRA-6916 - we remove the biggest sstable from the sstables we compact, but we never unmark it as compacting. Could you have a look at my fix? was (Author: krummas): [~JoshuaMcKenzie] attaching the 2.1-patch, seems we have a bug in CompactionTask#reduceForLimitedScope since CASSANDRA-6916 - we remove the biggest sstable from the sstables we compact, but we never unmark them as compacting. Could you have a look at my fix? > Fix checking available disk space before compaction starts > ---------------------------------------------------------- > > Key: CASSANDRA-8562 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8562 > Project: Cassandra > Issue Type: Bug > Reporter: Marcus Eriksson > Assignee: Marcus Eriksson > Fix For: 2.0.12, 2.1.3 > > Attachments: 0001-Check-for-available-disk-space-before-starting-compa.patch, 8562-2.1-v2.txt > > > When starting a compaction we check if there is enough disk space available to start it, otherwise we might (for STCS) reduce the compaction so that the result could fit. Now (since CASSANDRA-8329) we check for the directory to write to a lot later and this can reduce the compaction after we have created the scanners. -- This message was sent by Atlassian JIRA (v6.3.4#6332)