Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E1FD71762D for ; Mon, 19 Jan 2015 15:42:33 +0000 (UTC) Received: (qmail 49409 invoked by uid 500); 19 Jan 2015 15:42:36 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 49366 invoked by uid 500); 19 Jan 2015 15:42:36 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 49354 invoked by uid 99); 19 Jan 2015 15:42:35 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 19 Jan 2015 15:42:35 +0000 Date: Mon, 19 Jan 2015 15:42:35 +0000 (UTC) From: "Jeremy Hanna (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-7432) Add new CMS GC flags to cassandra_env.sh for JVM later than 1.7.0_60 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-7432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14282609#comment-14282609 ] Jeremy Hanna commented on CASSANDRA-7432: ----------------------------------------- It looks like is in 2.0, but not 2.1 forward. > Add new CMS GC flags to cassandra_env.sh for JVM later than 1.7.0_60 > -------------------------------------------------------------------- > > Key: CASSANDRA-7432 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7432 > Project: Cassandra > Issue Type: Improvement > Components: Packaging > Reporter: graham sanderson > Assignee: Brandon Williams > Fix For: 2.0.10, 2.1.1 > > Attachments: 7432.txt > > > The new flags in question are as follows: > {code} > -XX:+CMSParallelInitialMarkEnabled > -XX:+CMSEdenChunksRecordAlways > {code} > Given we already have > {code} > JVM_OPTS="$JVM_OPTS -XX:+UseParNewGC" > JVM_OPTS="$JVM_OPTS -XX:+UseConcMarkSweepGC" > JVM_OPTS="$JVM_OPTS -XX:+CMSParallelRemarkEnabled" > JVM_OPTS="$JVM_OPTS -XX:+UseTLAB" > if [ "$JVM_ARCH" = "64-Bit" ] ; then > JVM_OPTS="$JVM_OPTS -XX:+UseCondCardMark" > fi > {code} > The assumption would be that people are at least running on large number CPU cores/threads > I would therefore recommend defaulting these flags if available - the only two possible downsides for {{+CMSEdenChunksRecordAlways}}: > 1) There is a new very short (probably un-contended) lock in the "slow" (non TLAB) eden allocation path with {{+CMSEdenChunksRecordAlways}}. I haven't detected this timing wise - this is the "slow" path after all > 2) If you are running with {{-XX:-UseCMSCompactAtFullCollection}} (not the default) *and* you call {{System.gc()}} then {{+CMSEdenChunksRecordAlways}} will expose you to a possible seg fault: (see > [http://bugs.java.com/bugdatabase/view_bug.do?bug_id=8021809]) -- This message was sent by Atlassian JIRA (v6.3.4#6332)