cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philip Thompson (JIRA)" <>
Subject [jira] [Updated] (CASSANDRA-8638) CQLSH -f option should ignore BOM in files
Date Fri, 23 Jan 2015 16:51:34 GMT


Philip Thompson updated CASSANDRA-8638:
    Reviewer: Philip Thompson  (was: Sotirios Delimanolis)

I don't think we need to respect the usage of a BOM as a possible word joiner, as that was
deprecated in Unicode 3.2, the current version of Unicode is 7.0.

I do think this patch should include the BOM for UTF-16 LE in addition to UTF-16 BE.

Running multiple string.replace() calls feels inefficient. [~thobbs], what do you think?

> CQLSH -f option should ignore BOM in files
> ------------------------------------------
>                 Key: CASSANDRA-8638
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>         Environment: Red Hat linux
>            Reporter: Sotirios Delimanolis
>            Priority: Trivial
>              Labels: cqlsh, lhf
>             Fix For: 2.1.3
>         Attachments: 0001-bug-CASSANDRA-8638.patch
> I fell in byte order mark trap trying to execute a CQL script through CQLSH. 
> The file contained the simple (plus BOM)
> {noformat}
> CREATE KEYSPACE IF NOT EXISTS xobni WITH replication = {'class': 'SimpleStrategy', 'replication_factor':
'3'}  AND durable_writes = true; 
> -- and another "CREATE TABLE bucket_flags" query
> {noformat}
> I executed the script
> {noformat}
> [~]$ cqlsh --file /home/selimanolis/Schema/patches/setup.cql 
> /home/selimanolis/Schema/patches/setup.cql:2:Invalid syntax at char 1
> /home/selimanolis/Schema/patches/setup.cql:2:  ´╗┐CREATE KEYSPACE IF NOT EXISTS test
WITH replication = {'class': 'SimpleStrategy', 'replication_factor': '3'}  AND durable_writes
= true; 
> /home/selimanolis/Schema/patches/setup.cql:2:  ^
> /home/selimanolis/Schema/patches/setup.cql:22:ConfigurationException: <ErrorMessage
code=2300 [Query invalid because of configuration issue] message="Cannot add column family
'bucket_flags' to non existing keyspace 'test'.">
> {noformat}
> I realized much later that the file had a BOM which was seemingly screwing with how CQLSH
parsed the file.
> It would be nice to have CQLSH ignore the BOM when processing files.

This message was sent by Atlassian JIRA

View raw message