cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksey Yeschenko (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-8414) Avoid loops over array backed iterators that call iter.remove()
Date Thu, 15 Jan 2015 13:27:35 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-8414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14278662#comment-14278662
] 

Aleksey Yeschenko commented on CASSANDRA-8414:
----------------------------------------------

I'm hesitant to add it to 2.0 at all, but, will commit once 2.0.12 is out (which is soon),
so that this gets some testing time before it gets into a 2.0-line release (2.0.13 if everything
is fine).

> Avoid loops over array backed iterators that call iter.remove()
> ---------------------------------------------------------------
>
>                 Key: CASSANDRA-8414
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8414
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Richard Low
>            Assignee: Jimmy MÃ¥rdell
>              Labels: performance
>             Fix For: 2.1.3, 2.0.13
>
>         Attachments: cassandra-2.0-8414-1.txt, cassandra-2.0-8414-2.txt, cassandra-2.0-8414-3.txt,
cassandra-2.0-8414-4.txt, cassandra-2.0-8414-5.txt, cassandra-2.1-8414-5.txt, cassandra-2.1-8414-6.txt
>
>
> I noticed from sampling that sometimes compaction spends almost all of its time in iter.remove()
in ColumnFamilyStore.removeDeletedStandard. It turns out that the cf object is using ArrayBackedSortedColumns,
so deletes are from an ArrayList. If the majority of your columns are GCable tombstones then
this is O(n^2). The data structure should be changed or a copy made to avoid this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message