cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksey Yeschenko (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-8268) Token serialization should not assume all tokens are created by the database partitioner
Date Wed, 28 Jan 2015 23:53:36 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-8268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14296093#comment-14296093
] 

Aleksey Yeschenko commented on CASSANDRA-8268:
----------------------------------------------

Code LGTM as is, but I'd prefer to rename two methods if you don't mind:

1. Make MS#serializationPartitioner() into MS#clusterPartitioner() or MS#globalPartitioner()
2. Make MS#verifyPartitioner() into MS#validatePartitioner(), and have it throw an AE (or
a RTE) right there, vs. returning a boolean and have its callers to assert.

> Token serialization should not assume all tokens are created by the database partitioner
> ----------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-8268
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8268
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Branimir Lambov
>            Assignee: Branimir Lambov
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: 8268.patch
>
>
> This is also a hidden reference to StorageService.getPartitioner within Token, but this
needs to be handled more carefully as we need to check whether tokens serialized with the
wrong partitioner could be present in user data.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message