cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksey Yeschenko (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-5657) remove deprecated metrics
Date Fri, 23 Jan 2015 01:04:08 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-5657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288523#comment-14288523
] 

Aleksey Yeschenko commented on CASSANDRA-5657:
----------------------------------------------

Attached nits.txt with some nits and issues fixed:
- fixed the mixup in SEP#newExecutor() argument order - StageManager#multiThreadedLowSignalStage()
was calling them in the wrong order otherwise
- removed unused fields in LatencyMetrics
- replaced silly looking Stage#isJmxHidden()

Otherwise the branch mostly LGTM, +1.

P.S. There are many imports in wrong order, redundant @Override-s when implementing interface/abstract
methods (I assume automatically generated), and else/catch on the same line as the closing
bracket. Ideally those should be fixed on commit.

> remove deprecated metrics
> -------------------------
>
>                 Key: CASSANDRA-5657
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5657
>             Project: Cassandra
>          Issue Type: Task
>          Components: Tools
>            Reporter: Jonathan Ellis
>            Assignee: T Jake Luciani
>              Labels: technical_debt
>             Fix For: 3.0
>
>         Attachments: 5657.txt, 5657v2.txt, nits.txt
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message