Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C4FD910883 for ; Thu, 18 Dec 2014 17:23:13 +0000 (UTC) Received: (qmail 25979 invoked by uid 500); 18 Dec 2014 17:23:13 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 25942 invoked by uid 500); 18 Dec 2014 17:23:13 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 25925 invoked by uid 99); 18 Dec 2014 17:23:13 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Dec 2014 17:23:13 +0000 Date: Thu, 18 Dec 2014 17:23:13 +0000 (UTC) From: "Benedict (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (CASSANDRA-8513) SSTableScanner may not acquire reference, but will still release it when closed MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Benedict created CASSANDRA-8513: ----------------------------------- Summary: SSTableScanner may not acquire reference, but will still release it when closed Key: CASSANDRA-8513 URL: https://issues.apache.org/jira/browse/CASSANDRA-8513 Project: Cassandra Issue Type: Bug Components: Core Reporter: Benedict Fix For: 2.1.3 getRangeSlice and related methods do not require a reference to perform a safe read, so during one it is possible for SSTableScanner to fail to acquire a reference to the table it's being created on. In this case it doesn't fail, but it also doesn't log that no reference was acquired; on close, it still releases the reference that it never held. We can fix this one of two ways: we can tell the scanner if we require a reference to be acquired; or we can track if one was obtained. The former is a bit more invasive but probably better, since we probably care if we fail to grab one in cases where we need it, and probably don't want to grab one otherwise. -- This message was sent by Atlassian JIRA (v6.3.4#6332)