Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Fri, 19 Dec 2014 17:31:14 +0000 (UTC)
From: "Benedict (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12762276.1418822372000.70266.1419010274123@Atlassian.JIRA>
In-Reply-To: <JIRA.12762276.1418822372000@Atlassian.JIRA>
References: <JIRA.12762276.1418822372000@Atlassian.JIRA>
 <JIRA.12762276.1418822372357@arcas>
Subject: [jira] [Commented] (CASSANDRA-8499) Ensure SSTableWriter cleans up
 properly after failure
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-8499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14253683#comment-14253683 ] 

Benedict commented on CASSANDRA-8499:
-------------------------------------

Everytime we fail to complete a flush or compaction we will leak the bloom filter data, so it is probably not _that_ uncommon. It's also a pretty small fix. But pretty agnostic about it, really, since clusters seem to have been surviving with it for years.

> Ensure SSTableWriter cleans up properly after failure
> -----------------------------------------------------
>
>                 Key: CASSANDRA-8499
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8499
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Benedict
>            Assignee: Benedict
>             Fix For: 2.0.12
>
>         Attachments: 8499-20.txt, 8499-21.txt
>
>
> In 2.0 we do not free a bloom filter, in 2.1 we do not free a small piece of offheap memory for writing compression metadata. In both we attempt to flush the BF despite having encountered an exception, making the exception slow to propagate.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)