Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B09E6101ED for ; Mon, 1 Dec 2014 16:15:13 +0000 (UTC) Received: (qmail 59683 invoked by uid 500); 1 Dec 2014 16:15:12 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 59646 invoked by uid 500); 1 Dec 2014 16:15:12 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 59634 invoked by uid 99); 1 Dec 2014 16:15:12 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Dec 2014 16:15:12 +0000 Date: Mon, 1 Dec 2014 16:15:12 +0000 (UTC) From: =?utf-8?Q?Jimmy_M=C3=A5rdell_=28JIRA=29?= To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-8312) Use live sstables in snapshot repair if possible MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-8312?page=3Dcom.atlas= sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D= 14229956#comment-14229956 ]=20 Jimmy M=C3=A5rdell commented on CASSANDRA-8312: ------------------------------------------ Ping on this. I'm okay if you think this patch is unnecessary due to CASSANDRA-7024, but = I'd still be very happy with some feedback on if this approach is correct. = [~krummas]? > Use live sstables in snapshot repair if possible > ------------------------------------------------ > > Key: CASSANDRA-8312 > URL: https://issues.apache.org/jira/browse/CASSANDRA-8312 > Project: Cassandra > Issue Type: Improvement > Reporter: Jimmy M=C3=A5rdell > Assignee: Jimmy M=C3=A5rdell > Priority: Minor > Attachments: cassandra-2.0-8312-1.txt > > > Snapshot repair can be very much slower than parallel repairs because of = the overhead of opening the SSTables in the snapshot. This is particular tr= ue when using LCS, as you typically have many smaller SSTables then. > I compared parallel and sequential repair on a small range on one of our = clusters (2*3 replicas). With parallel repair, this took 22 seconds. With s= equential repair (default in 2.0), the same range took 330 seconds! This is= an overhead of 330-22*6 =3D 198 seconds, just opening SSTables (there were= 1000+ sstables). Also, opening 1000 sstables for many smaller rangers sure= ly causes lots of memory churning. > The idea would be to list the sstables in the snapshot, but use the corre= sponding sstables in the live set if it's still available. For almost all s= stables, the original one should still exist. -- This message was sent by Atlassian JIRA (v6.3.4#6332)