Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Thu, 4 Dec 2014 14:33:13 +0000 (UTC)
From: "Rajanarayanan Thottuvaikkatumana (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12711577.1398891221000.75869.1417703593433@Atlassian.JIRA>
In-Reply-To: <JIRA.12711577.1398891221000@Atlassian.JIRA>
References: <JIRA.12711577.1398891221000@Atlassian.JIRA>
 <JIRA.12711577.1398891221973@arcas>
Subject: [jira] [Commented] (CASSANDRA-7124) Use JMX Notifications to
 Indicate Success/Failure of Long-Running Operations
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CASSANDRA-7124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14234236#comment-14234236 ] 

Rajanarayanan Thottuvaikkatumana commented on CASSANDRA-7124:
-------------------------------------------------------------

[~yukim], Thanks for the suggestions on the cleanup code. I have attached a patch for the compact with this. Please have a look at it. In this, I have not blocked the execution anywhere. Like the CleanupResult you have implemented, I have not implemented the corresponding version in the compact. I am not sure what are the metrics to be captured in the result object. If that is applicable to compaction, please let me know and I can implement the same. 

I have tested the code, made changes to the test cases and all the tests related to the compaction are passing. Apart from that I have run the {{./bin/nodetool -h localhost compact}} and that is also working. Checked the JMX console and made sure that the notifications are coming properly. Here are the unit tests where I have made changes and made sure that the tests are passing with the code changes
{code}
ant test -Dtest.name=CompactionsTest
ant test -Dtest.name=OneCompactionsTest
ant test -Dtest.name=RangeTombstoneTest
ant test -Dtest.name=KeyspaceTest
ant test -Dtest.name=SSTableReaderTest
ant test -Dtest.name=LongCompactionsTest
{code}

Please let me know if you have any suggestions on this. Thanks

> Use JMX Notifications to Indicate Success/Failure of Long-Running Operations
> ----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-7124
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7124
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>            Reporter: Tyler Hobbs
>            Assignee: Rajanarayanan Thottuvaikkatumana
>            Priority: Minor
>              Labels: lhf
>             Fix For: 3.0
>
>         Attachments: 7124-wip.txt, cassandra-trunk-compact-7124.txt
>
>
> If {{nodetool cleanup}} or some other long-running operation takes too long to complete, you'll see an error like the one in CASSANDRA-2126, so you can't tell if the operation completed successfully or not.  CASSANDRA-4767 fixed this for repairs with JMX notifications.  We should do something similar for nodetool cleanup, compact, decommission, move, relocate, etc.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)