cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aleksey Yeschenko (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-8261) Clean up schema metadata classes
Date Thu, 11 Dec 2014 14:00:14 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-8261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14242539#comment-14242539
] 

Aleksey Yeschenko commented on CASSANDRA-8261:
----------------------------------------------

Attached a rebased v2 with the renames.

The TODO is there for CASSANDRA-6717 to resolve (all of these 8261 patches are extracts from
the 6717 branch, actually).

Didn't touch javadoc, b/c many of those methods will be gone (all the ones that serialize
schema the old way and some others).

This is the last 8261 patch. The rest of the work will be completed in 6717.

> Clean up schema metadata classes
> --------------------------------
>
>                 Key: CASSANDRA-8261
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8261
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Aleksey Yeschenko
>            Assignee: Aleksey Yeschenko
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: 8261-isolate-hadcoded-system-tables.txt, 8261-isolate-serialization-code-v2.txt,
8261-isolate-serialization-code.txt, 8261-isolate-thrift-code.txt
>
>
> While working on CASSANDRA-6717, I've made some general cleanup changes to schema metadata
classes - distracted from the core purpose. Also, being distracted from it by other things,
every time I come back to it gives me a bit of a rebase hell.
> Thus I'm isolating those changes into a separate issue here, hoping to commit them one
by one, before I go back and finalize CASSANDRA-6717.
> The changes include:
> - moving all the toThrift/fromThrift conversion code to ThriftConversion, where it belongs
> - moving the complied system CFMetaData objects away from CFMetaData (to SystemKeyspace
and TracesKeyspace)
> - isolating legacy toSchema/fromSchema code into a separate class (LegacySchemaTables
- former DefsTables)
> - refactoring CFMetaData/KSMetaData fields to match CQL CREATE TABLE syntax, and encapsulating
more things in CompactionOptions/CompressionOptions/ReplicationOptions classes
> - moving the definition classes to the new 'schema' package



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message