cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rajanarayanan Thottuvaikkatumana (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-7124) Use JMX Notifications to Indicate Success/Failure of Long-Running Operations
Date Thu, 04 Dec 2014 14:33:13 GMT


Rajanarayanan Thottuvaikkatumana commented on CASSANDRA-7124:

[~yukim], Thanks for the suggestions on the cleanup code. I have attached a patch for the
compact with this. Please have a look at it. In this, I have not blocked the execution anywhere.
Like the CleanupResult you have implemented, I have not implemented the corresponding version
in the compact. I am not sure what are the metrics to be captured in the result object. If
that is applicable to compaction, please let me know and I can implement the same. 

I have tested the code, made changes to the test cases and all the tests related to the compaction
are passing. Apart from that I have run the {{./bin/nodetool -h localhost compact}} and that
is also working. Checked the JMX console and made sure that the notifications are coming properly.
Here are the unit tests where I have made changes and made sure that the tests are passing
with the code changes
ant test
ant test
ant test
ant test
ant test
ant test

Please let me know if you have any suggestions on this. Thanks

> Use JMX Notifications to Indicate Success/Failure of Long-Running Operations
> ----------------------------------------------------------------------------
>                 Key: CASSANDRA-7124
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>            Reporter: Tyler Hobbs
>            Assignee: Rajanarayanan Thottuvaikkatumana
>            Priority: Minor
>              Labels: lhf
>             Fix For: 3.0
>         Attachments: 7124-wip.txt, cassandra-trunk-compact-7124.txt
> If {{nodetool cleanup}} or some other long-running operation takes too long to complete,
you'll see an error like the one in CASSANDRA-2126, so you can't tell if the operation completed
successfully or not.  CASSANDRA-4767 fixed this for repairs with JMX notifications.  We should
do something similar for nodetool cleanup, compact, decommission, move, relocate, etc.

This message was sent by Atlassian JIRA

View raw message