Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cassandra.apache.org
Date: Wed, 26 Nov 2014 19:25:12 +0000 (UTC)
From: "Matt Brown (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12758049.1417029878000.29307.1417029912303@Atlassian.JIRA>
In-Reply-To: <JIRA.12758049.1417029878000@Atlassian.JIRA>
References: <JIRA.12758049.1417029878000@Atlassian.JIRA>
 <JIRA.12758049.1417029878372@arcas>
Subject: [jira] [Created] (CASSANDRA-8379) Remove filename and line number
 flags from default logging configuration
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

Matt Brown created CASSANDRA-8379:
-------------------------------------

             Summary: Remove filename and line number flags from default logging configuration
                 Key: CASSANDRA-8379
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8379
             Project: Cassandra
          Issue Type: Improvement
            Reporter: Matt Brown
            Priority: Minor


n the logging configuration that ships with the cassandra distribution (log4j-server.properties in 2.0, and logback.xml in 2.1), the rolling file appender is configured to print the file name and the line number of each logging event:

{code}log4j.appender.R.layout.ConversionPattern=%5p [%t] %d{ISO8601} %F (line %L) %m%n{code}

Both the log4j and logback documentation warn that generating the filename/line information is not a cheap operation.

>From the [log4j docs|http://logging.apache.org/log4j/1.2/apidocs/org/apache/log4j/PatternLayout.html]:

> WARNING Generating caller location information is extremely slow and should be avoided unless execution speed is not an issue.

>From [logback docs|http://logback.qos.ch/manual/layouts.html]:

> Generating the file information is not particularly fast. Thus, its use should be avoided unless execution speed is not an issue.

The implementation for both involves creating a new Throwable and then printing the stack trace for the throwable to find the file name or line number. I don't have data to back this up but the conventional advice that "throwing exceptions is slow" has to do with filling in the stacktrace.

It would make more sense for the logging configuration to simply use the logger/category name (%c) instead of the file name and to remove the line number part.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)