Return-Path: 
 <commits-return-117206-apmail-cassandra-commits-archive=cassandra.apache.org@cassandra.apache.org>
X-Original-To: apmail-cassandra-commits-archive@www.apache.org
Delivered-To: apmail-cassandra-commits-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 3D6F510C90
	for <apmail-cassandra-commits-archive@www.apache.org>;
 Sun, 16 Nov 2014 19:30:34 +0000 (UTC)
Received: (qmail 51690 invoked by uid 500); 16 Nov 2014 19:30:33 -0000
Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org
Received: (qmail 51652 invoked by uid 500); 16 Nov 2014 19:30:33 -0000
Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:commits-help@cassandra.apache.org>
List-Unsubscribe: <mailto:commits-unsubscribe@cassandra.apache.org>
List-Post: <mailto:commits@cassandra.apache.org>
List-Id: <commits.cassandra.apache.org>
Reply-To: dev@cassandra.apache.org
Delivered-To: mailing list commits@cassandra.apache.org
Received: (qmail 51639 invoked by uid 99); 16 Nov 2014 19:30:33 -0000
Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 16 Nov 2014 19:30:33 +0000
Date: Sun, 16 Nov 2014 19:30:33 +0000 (UTC)
From: "Rajanarayanan Thottuvaikkatumana (JIRA)" <jira@apache.org>
To: commits@cassandra.apache.org
Message-ID: <JIRA.12751912.1414744004000.511283.1416166233789@Atlassian.JIRA>
In-Reply-To: <JIRA.12751912.1414744004000@Atlassian.JIRA>
References: <JIRA.12751912.1414744004000@Atlassian.JIRA>
 <JIRA.12751912.1414744004006@arcas>
Subject: [jira] [Commented] (CASSANDRA-8228) Log malfunctioning host on
 prepareForRepair
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/CASSANDRA-8228?page=3Dcom.atlas=
sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D=
14214020#comment-14214020 ]=20

Rajanarayanan Thottuvaikkatumana commented on CASSANDRA-8228:
-------------------------------------------------------------

[~yukim], Thanks for the advice. Now here is the approach I am planning to =
take.=20

In the prepareForRepair method of the org.apache.cassandra.service.ActiveRe=
pairService class, before the callback definition, I am going to define an =
object like this
{code} AtomicReference<String> failedNode =3D new AtomicReference<String>()=
; {code}
Then in the OnFailure method of the callback definition, I am going to coll=
ect the address of the node in the above defined failedNodes variable like =
this
{code} failedNode.set(from.getHostAddress()); {code}

Then in the error message display section, I will see whether there is any =
value in the "failedNodes" variable and if yes, I will display that. Does t=
hat make sense? If yes, please let me know and I will provide a revised pat=
ch. Thanks=20


> Log malfunctioning host on prepareForRepair
> -------------------------------------------
>
>                 Key: CASSANDRA-8228
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8228
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Juho M=C3=A4kinen
>            Assignee: Rajanarayanan Thottuvaikkatumana
>            Priority: Trivial
>              Labels: lhf
>         Attachments: cassandra-trunk-8228.txt
>
>
> Repair startup goes thru ActiveRepairService.prepareForRepair() which mig=
ht result with "Repair failed with error Did not get positive replies from =
all endpoints." error, but there's no other logging regarding to this error=
.
> It seems that it would be trivial to modify the prepareForRepair() to log=
 the host address which caused the error, thus ease the debugging effort.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)