Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 67039C48A for ; Wed, 12 Nov 2014 23:35:36 +0000 (UTC) Received: (qmail 19779 invoked by uid 500); 12 Nov 2014 23:35:36 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 19749 invoked by uid 500); 12 Nov 2014 23:35:36 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 19735 invoked by uid 99); 12 Nov 2014 23:35:36 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Nov 2014 23:35:36 +0000 Date: Wed, 12 Nov 2014 23:35:36 +0000 (UTC) From: "Rajanarayanan Thottuvaikkatumana (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-7124) Use JMX Notifications to Indicate Success/Failure of Long-Running Operations MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-7124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14208895#comment-14208895 ] Rajanarayanan Thottuvaikkatumana commented on CASSANDRA-7124: ------------------------------------------------------------- If we change the return type of parallelAllSSTableOperation, one more challenge is that down the execution chain, at the calling level where the "forceKeyspaceCleanup" method is called, it expects an int return value. So till this point you cannot bubble up the Future object collection. Somewhere you have to drop that and return an int. In the case of the repair command, it starts the execution of a thread and then it increments a new AtomicInteger() and returns that number as the return value. So wouldn't it be better in the parallelAllSSTableOperation method itself we return something like and AtomicInteger() or something like that? So that we will not have issues down the line. Sorry about the long mails. I want to make sure that we do it right in the first place it self. Thanks > Use JMX Notifications to Indicate Success/Failure of Long-Running Operations > ---------------------------------------------------------------------------- > > Key: CASSANDRA-7124 > URL: https://issues.apache.org/jira/browse/CASSANDRA-7124 > Project: Cassandra > Issue Type: Improvement > Components: Tools > Reporter: Tyler Hobbs > Assignee: Rajanarayanan Thottuvaikkatumana > Priority: Minor > Labels: lhf > Fix For: 3.0 > > Attachments: cassandra-trunk-temp-7124.txt > > > If {{nodetool cleanup}} or some other long-running operation takes too long to complete, you'll see an error like the one in CASSANDRA-2126, so you can't tell if the operation completed successfully or not. CASSANDRA-4767 fixed this for repairs with JMX notifications. We should do something similar for nodetool cleanup, compact, decommission, move, relocate, etc. -- This message was sent by Atlassian JIRA (v6.3.4#6332)