cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joshua McKenzie (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-8320) 2.1.2: NullPointerException in SSTableWriter
Date Tue, 25 Nov 2014 23:13:14 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-8320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225364#comment-14225364
] 

Joshua McKenzie commented on CASSANDRA-8320:
--------------------------------------------

+1, though I'm hesitant that we're going further down the road of interrelationships between
SSTableReaders w/regards to the resources they're reference counted to protect.  Right now
we have replaces, replacedBy, both of which are protected behind a shared replaceLock on a
linked-list chain of SSTableReaders, and now we're adding the (admittedly temporally short)
notion of sharesBfWith.

ISTM that we might be better served with a centralized keeper of "ref counted low-level resources"
w/atomicity and self-deletion/release rather than trying to maintain locking guarantees across
multiple SSTableReaders in a chain and maintaining these relationships between them, all for
the purpose of cleanup.  This business of shuffling around who owns the closing of what resource
in tidy() by checking all of these flags is proving to be a pain point.

Either way - this looks like it should address the current problem here.

> 2.1.2: NullPointerException in SSTableWriter
> --------------------------------------------
>
>                 Key: CASSANDRA-8320
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8320
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Evgeny Pasynkov
>            Assignee: Marcus Eriksson
>             Fix For: 2.1.3
>
>         Attachments: 8320.patch
>
>
> After upgrading to 2.1.2, I've got tons of these exception in log:
> java.lang.NullPointerException: null
> 	at org.apache.cassandra.io.sstable.SSTableWriter.openEarly(SSTableWriter.java:381) ~[cassandra-all-2.1.2.jar:2.1.2]
> 	at org.apache.cassandra.io.sstable.SSTableRewriter.switchWriter(SSTableRewriter.java:295)
~[cassandra-all-2.1.2.jar:2.1.2]
> 	at org.apache.cassandra.io.sstable.SSTableRewriter.abort(SSTableRewriter.java:186) ~[cassandra-all-2.1.2.jar:2.1.2]
> 	at org.apache.cassandra.db.compaction.CompactionTask.runWith(CompactionTask.java:204)
~[cassandra-all-2.1.2.jar:2.1.2]
> 	at org.apache.cassandra.io.util.DiskAwareRunnable.runMayThrow(DiskAwareRunnable.java:48)
~[cassandra-all-2.1.2.jar:2.1.2]
> 	at org.apache.cassandra.utils.WrappedRunnable.run(WrappedRunnable.java:28) ~[cassandra-all-2.1.2.jar:2.1.2]
> 	at org.apache.cassandra.db.compaction.CompactionTask.executeInternal(CompactionTask.java:75)
~[cassandra-all-2.1.2.jar:2.1.2]
> 	at org.apache.cassandra.db.compaction.AbstractCompactionTask.execute(AbstractCompactionTask.java:59)
~[cassandra-all-2.1.2.jar:2.1.2]
> 	at org.apache.cassandra.db.compaction.CompactionManager$BackgroundCompactionTask.run(CompactionManager.java:232)
~[cassandra-all-2.1.2.jar:2.1.2]
> 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) ~[na:1.7.0_60]
> 	at java.util.concurrent.FutureTask.run(FutureTask.java:262) ~[na:1.7.0_60]
> 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) ~[na:1.7.0_60]
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) [na:1.7.0_60]
> 	at java.lang.Thread.run(Thread.java:745) [na:1.7.0_60]
> This error is prepended by the following problems:
> 12:59:59.632 [NonPeriodicTasks:1] ERROR o.a.c.io.sstable.SSTableDeletingTask - Unable
to delete E:\Upsource_11959\data\cassandra\data\system\schema_keyspaces-b0f2235744583cdb9631c43e59ce3676\system-schema_keyspaces-ka-4-Data.db
(it will be removed on server restart; we'll also retry after GC)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message