cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tyler Hobbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-8286) Regression in ORDER BY
Date Tue, 18 Nov 2014 20:37:34 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14216755#comment-14216755
] 

Tyler Hobbs commented on CASSANDRA-8286:
----------------------------------------

v2 patches are attached.  I also have branches here: [2.0|https://github.com/thobbs/cassandra/tree/CASSANDRA-8286],
[2.1|https://github.com/thobbs/cassandra/tree/CASSANDRA-8286-2.1], and [trunk|https://github.com/thobbs/cassandra/tree/CASSANDRA-8286-trunk].

bq. The patch for 2.0 does not compile as ModificationStatement need to be modified

Fixed

bq. I can understand why you used processSelection and selectionsNeedProcessing but as everything
else is about functions I find it a bit confusing.

In 2.1 and 3.0, it's also handling field selection for UDTs.  Once CASSANDRA-7396 is complete,
that will be another non-function case.

bq. Renaming SelectionWithFunctions to SelectionWithProcessing only in version 2.1 is not
really consistent

Fixed, thanks.

bq. It will be good if you can add also some unit tests to test the ordering behavior with
functions

The latest patches has some additional unit tests to cover ordering and ordering with functions
and field selections.

> Regression in ORDER BY
> ----------------------
>
>                 Key: CASSANDRA-8286
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8286
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Philip Thompson
>            Assignee: Tyler Hobbs
>              Labels: cql
>             Fix For: 2.0.12, 2.1.3
>
>         Attachments: 8286-2.0-v2.txt, 8286-2.0.txt, 8286-2.1-v2.txt, 8286-2.1.txt, 8286-trunk-v2.txt,
8286-trunk.txt
>
>
> The dtest {{cql_tests.py:TestCQL.order_by_multikey_test}} is now failing in 2.0:
> http://cassci.datastax.com/job/cassandra-2.0_dtest/lastCompletedBuild/testReport/cql_tests/TestCQL/order_by_multikey_test/history/
> This failure began at the commit for CASSANDRA-8178.
> The error message reads {code}======================================================================
> ERROR: order_by_multikey_test (cql_tests.TestCQL)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/Users/philipthompson/cstar/cassandra-dtest/dtest.py", line 524, in wrapped
>     f(obj)
>   File "/Users/philipthompson/cstar/cassandra-dtest/cql_tests.py", line 1807, in order_by_multikey_test
>     res = cursor.execute("SELECT col1 FROM test WHERE my_id in('key1', 'key2', 'key3')
ORDER BY col1;")
>   File "/Library/Python/2.7/site-packages/cassandra/cluster.py", line 1281, in execute
>     result = future.result(timeout)
>   File "/Library/Python/2.7/site-packages/cassandra/cluster.py", line 2771, in result
>     raise self._final_exception
> InvalidRequest: code=2200 [Invalid query] message="ORDER BY could not be used on columns
missing in select clause."{code}
> and occurs at the query {{SELECT col1 FROM test WHERE my_id in('key1', 'key2', 'key3')
ORDER BY col1;}}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message