cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dave Brosius (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-8241) Use javac instead of javassist
Date Tue, 11 Nov 2014 05:21:34 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-8241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14205958#comment-14205958
] 

Dave Brosius edited comment on CASSANDRA-8241 at 11/11/14 5:20 AM:
-------------------------------------------------------------------

TBH, not a big fan of either solution, each is nasty in its own right. I agree with Robert,
using Java Assist means you will always be in a state of catch up language wise. But relying
on eclipse means dragging an elephant of configuration test matrix problems around with you
forever.

My experience with user-provided source code level integration is just a painful painful thing.
I'm not sure it's worth it.

I'm also not a big fan of building prototype java code up in StringBuilders. Can we externalize
the prototype into a first class file that get's getResourceAsStream'ed in and modified thru
markers of some sort? 




was (Author: dbrosius):
TBH, not a big fan of either solution, each is nasty in its own right. I agree with Robert,
using Java Assist means you will always be in a state of catch up language wise. But relying
on eclipse means dragging an elephant of configuration test matrix problems around with you
forever.

I'm also not a big fan of building prototype java code up in StringBuilders. Can we externalize
the prototype into a first class file that get's getResourceAsStream'ed in and modified thru
markers of some sort? 



> Use javac instead of javassist
> ------------------------------
>
>                 Key: CASSANDRA-8241
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8241
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Robert Stupp
>            Assignee: Robert Stupp
>              Labels: udf
>             Fix For: 3.0
>
>         Attachments: 8241-ecj.txt, udf-java-javac.txt
>
>
> Using JDK's built-in Java-Compiler API has some advantages over javassist.
> Although compilation feels a bit slower, Java compiler API has some advantages:
> * boxing + unboxing works
> * generics work
> * compiler error messages are better (or at least known) and have line/column numbers
> The implementation does not use any temp files. Everything's in memory.
> Patch attached to this issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message