cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rajanarayanan Thottuvaikkatumana (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-8228) Log malfunctioning host on prepareForRepair
Date Tue, 11 Nov 2014 22:50:33 GMT


Rajanarayanan Thottuvaikkatumana commented on CASSANDRA-8228:

I had a look at the code of org.apache.cassandra.service.ActiveRepairService and as per my
understanding, when the error message comes after the code execution exception of "prepareLatch.await(1,
TimeUnit.HOURS);" OR when the status.get() returns false, we don't have an object that carries
the endpoint which did not provide the reply. Hence we will not be able to provide the host
address which caused the error. 

The other option is to iterate through all the endpoints and list the host addresses of all
of them and say "Some of the below list of endpoints did not provide positive reply" or some
thing of that sort. In an applications perspective, I am not sure whether that makes sense.
But it can give some additional information to the error for sure. Please let me know whether
this is to be implemented or not. I can make those changes. Thanks

> Log malfunctioning host on prepareForRepair
> -------------------------------------------
>                 Key: CASSANDRA-8228
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Juho Mäkinen
>            Priority: Trivial
>              Labels: lhf
> Repair startup goes thru ActiveRepairService.prepareForRepair() which might result with
"Repair failed with error Did not get positive replies from all endpoints." error, but there's
no other logging regarding to this error.
> It seems that it would be trivial to modify the prepareForRepair() to log the host address
which caused the error, thus ease the debugging effort.

This message was sent by Atlassian JIRA

View raw message