cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <>
Subject [jira] [Commented] (CASSANDRA-7859) Extend freezing to collections
Date Fri, 07 Nov 2014 10:39:34 GMT


Sylvain Lebresne commented on CASSANDRA-7859:

bq. Does that clarify things?

Yes, you're right, I was a bit quick in doing my comments.

That said, those functions are still a bit hard to read, and instead of having {{CollectionType.isMultiCellCompatibleWith}}
and every concrete collection {{isCompatibleWith}} method starting by {{if isMultiCell() return
isMultipleCellCompatibleWith}}, I'd prefer having {{CollectionType}} directly implement {{isCompatibleWith}}
for multiCell, and delegate just the non-multiCell case to an abstract method implemented
by all concrete collections. But I'm good with you doing that upon commit.

bq. What do you think about my comment on 8264 and getRequestedColumns?

I finally had a look at the changes and it does look reasonable so I'm fine including them
here an leaving what remains to CASSANDRA-8264.

Overall, +1.

> Extend freezing to collections
> ------------------------------
>                 Key: CASSANDRA-7859
>                 URL:
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Sylvain Lebresne
>            Assignee: Tyler Hobbs
>              Labels: cql
>             Fix For: 2.1.2
>         Attachments: 7859-v1.txt
> This is the follow-up to CASSANDRA-7857, to extend {{frozen}} to collections. This will
allow things like {{map<text, frozen<map<int, int>>>}} for instance, as
well as allowing {{frozen}} collections in PK columns.
> Additionally (and that's alsmot a separate ticket but I figured we can start discussing
it here), we could decide that tuple is a frozen type by default. This means that we would
allow {{tuple<int, text>}} without needing to add {{frozen}}, but we would require {{frozen}}
for complex type inside tuple, so {{tuple<int, list<text>>}} would be rejected,
but not {{tuple<int, frozen<list<text>>>}}.

This message was sent by Atlassian JIRA

View raw message