cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dave Brosius (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (CASSANDRA-7586) Mark SSTables as repaired after full repairs
Date Tue, 04 Nov 2014 02:09:34 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-7586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14195571#comment-14195571
] 

Dave Brosius edited comment on CASSANDRA-7586 at 11/4/14 2:08 AM:
------------------------------------------------------------------

Something seems odd here. mind taking a look to recheck?
{code}
+        public void addSSTables(UUID cfId, Set<SSTableReader> sstables)
+        {
+            Set<SSTableReader> existingSSTables = this.sstableMap.get(cfId);
+            if (existingSSTables == null)
+                existingSSTables = new HashSet<>();
+            existingSSTables.addAll(sstables);
+            this.sstableMap.put(cfId, sstables);
         }
{code}
In the case that existingSSTables is null, you create a new one, add sstables to it, but then
don't do anything with that newly created set. Was that supposed to be this.sstableMap.put(cfId,
existingSSTables); ?


was (Author: dbrosius):
Something seems odd here. mind taking a look to recheck?

+        public void addSSTables(UUID cfId, Set<SSTableReader> sstables)
+        {
+            Set<SSTableReader> existingSSTables = this.sstableMap.get(cfId);
+            if (existingSSTables == null)
+                existingSSTables = new HashSet<>();
+            existingSSTables.addAll(sstables);
+            this.sstableMap.put(cfId, sstables);
         }

In the case that existingSSTables is null, you create a new one, add sstables to it, but then
don't do anything with that newly created set. Was that supposed to be this.sstableMap.put(cfId,
existingSSTables); ?

> Mark SSTables as repaired after full repairs
> --------------------------------------------
>
>                 Key: CASSANDRA-7586
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7586
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Marcus Eriksson
>            Assignee: Marcus Eriksson
>             Fix For: 3.0
>
>
> In 2.1 we avoided anticompaction and marking sstables as repaired after old-style full
repairs (reasoning was that we wanted users to be able to carry on as before)
> In 3.0 incremental repairs is on by default and we should always mark and anticompact
sstables



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message