cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rajanarayanan Thottuvaikkatumana (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-7124) Use JMX Notifications to Indicate Success/Failure of Long-Running Operations
Date Fri, 21 Nov 2014 00:03:36 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-7124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14220264#comment-14220264
] 

Rajanarayanan Thottuvaikkatumana commented on CASSANDRA-7124:
-------------------------------------------------------------

[~yukim], As per your suggestions, consolidated the "performCleanup" call fixed the class
cast exception etc, did some testing and attached the patch for the same. Please have a look
at it. Here are some of the test results 

Ran the "./bin/nodetool -h localhost cleanup" command and found working and here is the output
I could see from the console
{code}
INFO  23:44:21 Starting cleanup command #2, cleaning up keyspace system_traces with column
family store sessions
INFO  23:44:21 Starting cleanup command #1, cleaning up keyspace system_traces with column
family store events
INFO  23:44:21 No sstables for system_traces.events
INFO  23:44:21 No sstables for system_traces.sessions
INFO  23:44:21 Ending cleanup command #2, cleaning up keyspace system_traces with column family
store sessions
INFO  23:44:21 Ending cleanup command #1, cleaning up keyspace system_traces with column family
store events
{code}

Ran the CleanupTest (since the performCleanup is calling the changed code, I didn't have to
make any changes to the test code) and found working. Here is the test output.

{code}
Rajanarayanans-MacBook-Pro:cassandra-trunk RajT$ ant test -Dtest.name=CleanupTest
Buildfile: /Users/RajT/cassandra-source/cassandra-trunk/build.xml

init:

maven-ant-tasks-localrepo:

maven-ant-tasks-download:

maven-ant-tasks-init:

maven-declare-dependencies:

maven-ant-tasks-retrieve-build:

init-dependencies:
     [echo] Loading dependency paths from file: /Users/RajT/cassandra-source/cassandra-trunk/build/build-dependencies.xml
    [unzip] Expanding: /Users/RajT/cassandra-source/cassandra-trunk/build/lib/jars/org.jacoco.agent-0.7.1.201405082137.jar
into /Users/RajT/cassandra-source/cassandra-trunk/build/lib/jars

check-gen-cql3-grammar:

gen-cql3-grammar:

build-project:
     [echo] apache-cassandra: /Users/RajT/cassandra-source/cassandra-trunk/build.xml

createVersionPropFile:
[propertyfile] Updating property file: /Users/RajT/cassandra-source/cassandra-trunk/src/resources/org/apache/cassandra/config/version.properties
     [copy] Copying 1 file to /Users/RajT/cassandra-source/cassandra-trunk/build/classes/main

build:

build-test:

test:

testlist:
     [echo] running test bucket 0 tests
    [mkdir] Created dir: /Users/RajT/cassandra-source/cassandra-trunk/build/test/cassandra
    [mkdir] Created dir: /Users/RajT/cassandra-source/cassandra-trunk/build/test/output
    [junit] WARNING: multiple versions of ant detected in path for junit 
    [junit]          jar:file:/usr/local/Cellar/ant/1.9.4/libexec/lib/ant.jar!/org/apache/tools/ant/Project.class
    [junit]      and jar:file:/Users/RajT/cassandra-source/cassandra-trunk/build/lib/jars/ant-1.6.5.jar!/org/apache/tools/ant/Project.class
    [junit] objc[3711]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_67.jdk/Contents/Home/jre/bin/java
and /Library/Java/JavaVirtualMachines/jdk1.7.0_67.jdk/Contents/Home/jre/lib/libinstrument.dylib.
One of the two will be used. Which one is undefined.
    [junit] Testsuite: org.apache.cassandra.db.CleanupTest
    [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.217 sec
    [junit] 
    [junit] ------------- Standard Output ---------------
    [junit] WARN  23:43:07 JNA link failure, one or more native method will be unavailable.
    [junit] WARN  23:43:07 JNA link failure, one or more native method will be unavailable.
    [junit] WARN  23:43:07 Couldn't open /proc/stats
    [junit] WARN  23:43:07 Couldn't open /proc/stats
    [junit] ------------- ---------------- ---------------
[junitreport] Processing /Users/RajT/cassandra-source/cassandra-trunk/build/test/TESTS-TestSuites.xml
to /var/folders/nf/trtmyt9534z03kq8p8zgbnxh0000gn/T/null1933090667
[junitreport] Loading stylesheet jar:file:/usr/local/Cellar/ant/1.9.4/libexec/lib/ant-junit.jar!/org/apache/tools/ant/taskdefs/optional/junit/xsl/junit-frames.xsl
[junitreport] Transform time: 387ms
[junitreport] Deleting: /var/folders/nf/trtmyt9534z03kq8p8zgbnxh0000gn/T/null1933090667

BUILD SUCCESSFUL
Total time: 4 seconds

{code}

> Use JMX Notifications to Indicate Success/Failure of Long-Running Operations
> ----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-7124
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-7124
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Tools
>            Reporter: Tyler Hobbs
>            Assignee: Rajanarayanan Thottuvaikkatumana
>            Priority: Minor
>              Labels: lhf
>             Fix For: 3.0
>
>         Attachments: cassandra-trunk-cleanup-7124.txt
>
>
> If {{nodetool cleanup}} or some other long-running operation takes too long to complete,
you'll see an error like the one in CASSANDRA-2126, so you can't tell if the operation completed
successfully or not.  CASSANDRA-4767 fixed this for repairs with JMX notifications.  We should
do something similar for nodetool cleanup, compact, decommission, move, relocate, etc.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message