Return-Path: X-Original-To: apmail-cassandra-commits-archive@www.apache.org Delivered-To: apmail-cassandra-commits-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7DC46176F2 for ; Wed, 22 Oct 2014 17:50:36 +0000 (UTC) Received: (qmail 41315 invoked by uid 500); 22 Oct 2014 17:50:36 -0000 Delivered-To: apmail-cassandra-commits-archive@cassandra.apache.org Received: (qmail 41282 invoked by uid 500); 22 Oct 2014 17:50:36 -0000 Mailing-List: contact commits-help@cassandra.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cassandra.apache.org Delivered-To: mailing list commits@cassandra.apache.org Received: (qmail 41268 invoked by uid 99); 22 Oct 2014 17:50:36 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Oct 2014 17:50:36 +0000 Date: Wed, 22 Oct 2014 17:50:36 +0000 (UTC) From: "Ben Chan (JIRA)" To: commits@cassandra.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (CASSANDRA-5483) Repair tracing MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CASSANDRA-5483?page=3Dcom.atlas= sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D= 14180236#comment-14180236 ]=20 Ben Chan commented on CASSANDRA-5483: ------------------------------------- I'm not planning on making any more changes pre-review. Feel free to go ahe= ad. (Though it would have been fine even if you had started prior to 5483-v17-0= 0 and 5483-v17-01; the differences are not substantial) > Repair tracing > -------------- > > Key: CASSANDRA-5483 > URL: https://issues.apache.org/jira/browse/CASSANDRA-5483 > Project: Cassandra > Issue Type: Improvement > Components: Tools > Reporter: Yuki Morishita > Assignee: Ben Chan > Priority: Minor > Labels: repair > Fix For: 3.0 > > Attachments: 5483-full-trunk.txt, 5483-v06-04-Allow-tracing-ttl-t= o-be-configured.patch, 5483-v06-05-Add-a-command-column-to-system_traces.ev= ents.patch, 5483-v06-06-Fix-interruption-in-tracestate-propagation.patch, 5= 483-v07-07-Better-constructor-parameters-for-DebuggableThreadPoolExecutor.p= atch, 5483-v07-08-Fix-brace-style.patch, 5483-v07-09-Add-trace-option-to-a-= more-complete-set-of-repair-functions.patch, 5483-v07-10-Correct-name-of-bo= olean-repairedAt-to-fullRepair.patch, 5483-v08-11-Shorten-trace-messages.-U= se-Tracing-begin.patch, 5483-v08-12-Trace-streaming-in-Differencer-Streamin= gRepairTask.patch, 5483-v08-13-sendNotification-of-local-traces-back-to-nod= etool.patch, 5483-v08-14-Poll-system_traces.events.patch, 5483-v08-15-Limit= -trace-notifications.-Add-exponential-backoff.patch, 5483-v09-16-Fix-hang-c= aused-by-incorrect-exit-code.patch, 5483-v10-17-minor-bugfixes-and-changes.= patch, 5483-v10-rebased-and-squashed-471f5cc.patch, 5483-v11-01-squashed.pa= tch, 5483-v11-squashed-nits.patch, 5483-v12-02-cassandra-yaml-ttl-doc.patch= , 5483-v13-608fb03-May-14-trace-formatting-changes.patch, 5483-v14-01-squas= hed.patch, 5483-v15-02-Hook-up-exponential-backoff-functionality.patch, 548= 3-v15-03-Exact-doubling-for-exponential-backoff.patch, 5483-v15-04-Re-add-o= ld-StorageService-JMX-signatures.patch, 5483-v15-05-Move-command-column-to-= system_traces.sessions.patch, 5483-v15.patch, 5483-v17-00.patch, 5483-v17-0= 1.patch, 5483-v17.patch, ccm-repair-test, cqlsh-left-justify-text-columns.p= atch, prerepair-vs-postbuggedrepair.diff, test-5483-system_traces-events.tx= t, trunk@4620823-5483-v02-0001-Trace-filtering-and-tracestate-propagation.p= atch, trunk@4620823-5483-v02-0002-Put-a-few-traces-parallel-to-the-repair-l= ogging.patch, trunk@8ebeee1-5483-v01-001-trace-filtering-and-tracestate-pro= pagation.txt, trunk@8ebeee1-5483-v01-002-simple-repair-tracing.txt, v02p02-= 5483-v03-0003-Make-repair-tracing-controllable-via-nodetool.patch, v02p02-5= 483-v04-0003-This-time-use-an-EnumSet-to-pass-boolean-repair-options.patch,= v02p02-5483-v05-0003-Use-long-instead-of-EnumSet-to-work-with-JMX.patch > > > I think it would be nice to log repair stats and results like query traci= ng stores traces to system keyspace. With it, you don't have to lookup each= log file to see what was the status and how it performed the repair you in= voked. Instead, you can query the repair log with session ID to see the sta= te and stats of all nodes involved in that repair session. -- This message was sent by Atlassian JIRA (v6.3.4#6332)