cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tyler Hobbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-8183) improve PropertyFileSnitch output
Date Fri, 24 Oct 2014 16:53:34 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-8183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14183038#comment-14183038
] 

Tyler Hobbs commented on CASSANDRA-8183:
----------------------------------------

Thanks for the patch!

Here's my feedback:
* I appreciate the attempt to apply a map operation, but it's pretty unwieldy in Java, and
a simple for-loop would be clearer and shorter here.
* We don't typically use @Nullable (or @NotNull) annotations
* This can be applied to 2.0, which has the same behavior.

> improve PropertyFileSnitch output
> ---------------------------------
>
>                 Key: CASSANDRA-8183
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8183
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Config
>            Reporter: Liang Xie
>            Assignee: Liang Xie
>            Priority: Trivial
>             Fix For: 2.0.10, 2.1.2
>
>         Attachments: CASSANDRA-8183.txt
>
>
> Saw log like this: "16:37:11.825 [main] DEBUG o.a.c.locator.PropertyFileSnitch - loaded
network topology /10.2.201.66:[Ljava.lang.String;@34e276d9, /10.2.201.65:[Ljava.lang.String;@7fe8bbae,
/10.2.201. 68:[Ljava.lang.String;@879de1d"
> Obviously, we should handle the original String Array output behavior better.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message