cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brandon Williams (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-8113) Gossip should ignore generation numbers too far in the future
Date Tue, 14 Oct 2014 18:16:34 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-8113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14171299#comment-14171299
] 

Brandon Williams commented on CASSANDRA-8113:
---------------------------------------------

I'm more leery about the max version check since technically the version has no bounds, and
possibly you could someday have something minor get out of whack like severity but it shouldn't
effectively make the node be ignore.  Plus if you get a bit flipped in a version making it
artificially high, simple restarting the node would fix it since it will have a superior generation
after that.  What you can't do is easily fix the artificially generation as easily since you
basically have to assassinate it at that point.  So, I would say drop the version check since
there's some risk of a regression there and it's a little overly zealous since that's trivial
to solve if it does happen. (and then rename max_version since it's not looking at versions)

> Gossip should ignore generation numbers too far in the future
> -------------------------------------------------------------
>
>                 Key: CASSANDRA-8113
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8113
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Richard Low
>            Assignee: Jason Brown
>         Attachments: 8113-v1.txt, 8113-v2.txt, 8113-v3.txt
>
>
> If a node sends corrupted gossip, it could set the generation numbers for other nodes
to arbitrarily large values. This is dangerous since one bad node (e.g. with bad memory) could
in theory bring down the cluster. Nodes should refuse to accept generation numbers that are
too far in the future.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message