cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tyler Hobbs (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-8109) Avoid constant boxing in ColumnStats.{Min/Max}Tracker
Date Thu, 16 Oct 2014 21:02:34 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-8109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14174235#comment-14174235
] 

Tyler Hobbs commented on CASSANDRA-8109:
----------------------------------------

[~rnamboodiri] trunk isn't completely stable yet, so some test failures are expected.  In
the case of this ticket, the compiler should be able to guarantee the safety of the changes,
so go ahead and attach your patch.

> Avoid constant boxing in ColumnStats.{Min/Max}Tracker
> -----------------------------------------------------
>
>                 Key: CASSANDRA-8109
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8109
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Sylvain Lebresne
>            Assignee: Rajanarayanan Thottuvaikkatumana
>            Priority: Minor
>              Labels: lhf
>             Fix For: 3.0
>
>
> We use the {{ColumnStats.MinTracker}} and {{ColumnStats.MaxTracker}} to track timestamps
and deletion times in sstable. Those classes are generics but we really ever use them for
longs and integers. The consequence is that every call to their {{update}} method (called
for every cell during sstable write) box it's argument (since we don't store the cell timestamps
and deletion time boxed). That feels like a waste that is easy to fix: we could just make
those work on longs only for instance and convert back to int at the end when that's what
we need.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message