cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sylvain Lebresne (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (CASSANDRA-8054) EXECUTE request with skipMetadata=false gets no metadata in response
Date Mon, 06 Oct 2014 10:00:34 GMT

     [ https://issues.apache.org/jira/browse/CASSANDRA-8054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sylvain Lebresne updated CASSANDRA-8054:
----------------------------------------
    Attachment: 8054-v2.txt

[This comment|https://issues.apache.org/jira/browse/CASSANDRA-7120?focusedCommentId=14005790&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14005790]
on CASSANDRA-7120 applies here as well, we have to copy the whole metadata, not just the {{names}}.
On CASSANDRA-7120 I advocated for saving the allocation of a new Metatdata object when there
is no paging state, but extending this to this case is probably a bit more dangerous than
anything else, so attaching patch that somewhat revert CASSANDRA-7120 solution and copy the
whole metadata instead.

> EXECUTE request with skipMetadata=false gets no metadata in response
> --------------------------------------------------------------------
>
>                 Key: CASSANDRA-8054
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8054
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Olivier Michallat
>         Attachments: 8054-2.1.txt, 8054-v2.txt
>
>
> This has been reported independently with the [Java|https://datastax-oss.atlassian.net/browse/JAVA-482]
and [C++|https://datastax-oss.atlassian.net/browse/CPP-174] drivers.
> This happens under heavy load, where multiple client threads prepare and execute statements
in parallel. One of them sends an EXECUTE request with skipMetadata=false, but the returned
ROWS response has no metadata in it.
> A patch of {{Message.Dispatcher.channelRead0}} confirmed that the flag was incorrectly
set on the response:
> {code}
>                 logger.debug("Received: {}, v={}", request, connection.getVersion());
>                 boolean skipMetadataOnRequest = false;
>                 if (request instanceof ExecuteMessage) {
>                     ExecuteMessage execute = (ExecuteMessage)request;
>                     skipMetadataOnRequest = execute.options.skipMetadata();
>                 }
>                 response = request.execute(qstate);
>                 if (request instanceof ExecuteMessage) {
>                     Rows rows = (Rows)response;
>                     boolean skipMetadataOnResponse = rows.result.metadata.flags.contains(Flag.NO_METADATA);
>                     if (skipMetadataOnResponse != skipMetadataOnRequest) {
>                         logger.warn("Inconsistent skipMetadata on streamId {}, was {}
in request but {} in response",
>                                     request.getStreamId(),
>                                     skipMetadataOnRequest,
>                                     skipMetadataOnResponse);
>                     }
>                 }
> {code}
> We observed the warning with (false, true) during our tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message