cassandra-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "sankalp kohli (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CASSANDRA-5839) Save repair data to system table
Date Wed, 29 Oct 2014 01:07:35 GMT

    [ https://issues.apache.org/jira/browse/CASSANDRA-5839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14187839#comment-14187839
] 

sankalp kohli commented on CASSANDRA-5839:
------------------------------------------

By 1) I mean we are keeping two list of system keyspaces in Schema and DatabaseDescriptor.
Why not clean it up to just one. Keep it only in Schema. 

I reviewed the patch. 
1) RepairResultPersister.failure is setting the status as success. Looks like a typo. 
2) The comment on top of RepairResultPersister is confusing. It is keeping track of a RepairSession
and not RepairJob. 
3) Since we are combining the Future of all repair jobs to one, if one of them will fail,
it will cause us to write that repair failed for all CFs. 

> Save repair data to system table
> --------------------------------
>
>                 Key: CASSANDRA-5839
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-5839
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Core, Tools
>            Reporter: Jonathan Ellis
>            Assignee: Marcus Eriksson
>            Priority: Minor
>             Fix For: 3.0
>
>         Attachments: 0001-5839.patch, 2.0.4-5839-draft.patch, 2.0.6-5839-v2.patch
>
>
> As noted in CASSANDRA-2405, it would be useful to store repair results, particularly
with sub-range repair available (CASSANDRA-5280).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message